Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable more precompilation on Windows #4617

Merged
merged 1 commit into from Jan 3, 2023

Conversation

KristofferC
Copy link
Contributor

This works around JuliaLang/julia/issues/46989 and give good speedups on 1.9.0:

Before:

julia> @time (p = plot(rand(2,2)); display(p))
  3.102817 seconds (9.33 M allocations: 580.555 MiB, 3.48% gc time, 141.40% compilation time: <1% of which was recompilation)

After:

julia> @time (p = plot(rand(2,2)); display(p))
  0.190534 seconds (75.80 k allocations: 4.387 MiB, 93.92% compilation time: 7% of which was recompilation)

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 90.65% // Head: 90.78% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (5af5576) compared to base (3fe21ae).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4617      +/-   ##
==========================================
+ Coverage   90.65%   90.78%   +0.13%     
==========================================
  Files          41       41              
  Lines        8772     8773       +1     
==========================================
+ Hits         7952     7965      +13     
+ Misses        820      808      -12     
Impacted Files Coverage Δ
src/init.jl 100.00% <ø> (ø)
src/backends/gr.jl 91.66% <100.00%> (+<0.01%) ⬆️
RecipesPipeline/src/utils.jl 97.26% <0.00%> (+1.36%) ⬆️
RecipesPipeline/src/series.jl 93.58% <0.00%> (+2.56%) ⬆️
src/examples.jl 99.20% <0.00%> (+3.17%) ⬆️
RecipesPipeline/src/RecipesPipeline.jl 100.00% <0.00%> (+11.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥲

@BeastyBlacksmith BeastyBlacksmith merged commit f0b4b08 into JuliaPlots:master Jan 3, 2023
@KristofferC KristofferC deleted the kc/win_prec branch January 3, 2023 21:57
@KristofferC
Copy link
Contributor Author

I can haz release? :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants