Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify open #4642

Merged
merged 1 commit into from
Jan 27, 2023
Merged

simplify open #4642

merged 1 commit into from
Jan 27, 2023

Conversation

t-bltg
Copy link
Member

@t-bltg t-bltg commented Jan 26, 2023

While trying to fix nightly.
Seems like there is a missing close somewhere...

@t-bltg t-bltg added the nfc non-functional change label Jan 26, 2023
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Base: 90.80% // Head: 90.76% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (abb2fad) compared to base (54a215f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4642      +/-   ##
==========================================
- Coverage   90.80%   90.76%   -0.05%     
==========================================
  Files          41       41              
  Lines        8778     8781       +3     
==========================================
- Hits         7971     7970       -1     
- Misses        807      811       +4     
Impacted Files Coverage Δ
RecipesPipeline/src/group.jl 90.54% <0.00%> (-4.06%) ⬇️
src/layouts.jl 95.46% <0.00%> (-0.29%) ⬇️
src/backends.jl 82.58% <0.00%> (+0.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@t-bltg t-bltg merged commit ae88be7 into JuliaPlots:master Jan 27, 2023
@t-bltg t-bltg deleted the open branch January 27, 2023 12:08
@BeastyBlacksmith
Copy link
Member

BeastyBlacksmith commented Jan 27, 2023

Seems like there is a missing close somewhere...

Are you sure? It looks more like a bug in Pkg/ julia to me.

@t-bltg
Copy link
Member Author

t-bltg commented Jan 27, 2023

I mean by that on nightly we hang waiting for some i/o operations, I vaguely recall seeing something similar induced by a missing close in some discussion in the julia repo (but don't recall which one ...).

[pid 8003] waiting for IO to finish:
 TYPE[FD/PID]       @UV_HANDLE_T->DATA
 pipe[18]           @0x29f8660->0x7f1664428880
 pipe[12]           @0x307d3b0->0x7f1664428920
 process[8015]      @0x2be3af0->0x7f1664c696d0

Probably minor (likely to be fixed by future commits on julia@master), but let's keep an eye on this. Seems related to the precompilation failure (obscure message about inference failure).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nfc non-functional change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants