Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support removing colorbar ticks in GR and PGFPlotsX #4704

Merged
merged 5 commits into from Mar 24, 2023
Merged

Support removing colorbar ticks in GR and PGFPlotsX #4704

merged 5 commits into from Mar 24, 2023

Conversation

ivan-boikov
Copy link
Contributor

Description

Related #4659
I also took the liberty of rearranging assembly of colorbar parameters in PGFPlotsX to reduce code redundancy (it also helped for the patch). Hope that's alright.

Testing code
testplot = (; kwargs...) -> plot([0,1]; label=:none, zcolor=[0,1], kwargs...)
plot(
    testplot(),
    testplot(; colorbar_ticks=:none)
)

Before fix
image image

After fix
image image

Attribution

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (fbdaa89) 90.42% compared to head (d6363b8) 90.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4704      +/-   ##
==========================================
- Coverage   90.42%   90.41%   -0.01%     
==========================================
  Files          40       40              
  Lines        8719     8723       +4     
==========================================
+ Hits         7884     7887       +3     
- Misses        835      836       +1     
Impacted Files Coverage Δ
src/backends/gr.jl 90.68% <100.00%> (+<0.01%) ⬆️
src/backends/pgfplotsx.jl 88.29% <100.00%> (-0.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeastyBlacksmith BeastyBlacksmith merged commit a16a21a into JuliaPlots:master Mar 24, 2023
13 of 15 checks passed
@ivan-boikov ivan-boikov deleted the ib-pgfx-colorbar-ticks branch March 24, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants