Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Animation constructor #4830

Merged
merged 5 commits into from
Oct 19, 2023
Merged

Add missing Animation constructor #4830

merged 5 commits into from
Oct 19, 2023

Conversation

agdestein
Copy link
Contributor

@agdestein agdestein commented Oct 4, 2023

Description

This adds a constructor Animation(dir) in addition to the two existing ones Animation() and Animation(dir, frames).
The docstring already mentions Animation(dir) as an option (see #4568).

Attribution

Things to consider

  • Does it work on log scales?
  • Does it work in layouts?
  • Does it work in recipes?
  • Does it work with multiple series in one call?
  • PR includes or updates tests?
  • PR includes or updates documentation?

@agdestein agdestein marked this pull request as ready for review October 5, 2023 17:41
@BeastyBlacksmith
Copy link
Member

Would you mind adding a test?

@agdestein
Copy link
Contributor Author

If dir does not exist, adding a frame throws a SystemError (missing directory). We could alternatively create this directory in the constructor, e.g. ispath(dir) || mkpath(dir). This is also done for the empty constructor with mktempdir.

@BeastyBlacksmith
Copy link
Member

I think the current behaviour is reasonable.

@BeastyBlacksmith BeastyBlacksmith merged commit 0dbcd90 into JuliaPlots:master Oct 19, 2023
8 of 14 checks passed
@agdestein agdestein deleted the fix-animation-constructor branch October 19, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants