New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework docstrings #206
Rework docstrings #206
Conversation
af68f85
to
1b84241
Compare
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
=======================================
Coverage 99.57% 99.58%
=======================================
Files 24 25 +1
Lines 1180 1200 +20
=======================================
+ Hits 1175 1195 +20
Misses 5 5
Continue to review full report at Codecov.
|
285d9c9
to
df84c70
Compare
f6441f4
to
ac8d5fc
Compare
5c3907e
to
4a2b1eb
Compare
@johnnychen94, just to let you know that I think the PR is ready for review (nothing urgent though 😉 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat!
Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
7d6148d
to
776b1a2
Compare
This PR automates docstring generation for arguments, function signatures, and
README.md
. Fix #45 ?Rationale:
200+
lines of docstring code (with duplicates) for the same result.README.md
(default keywords), andgen_imgs.jl
file for updating the examples).The auto-generated
README.md
can be seen here, it should be rendered close to the existing one. It didn't want to pull inDocumenter.jl
, I'm just usingMarkdown
from the stdlib to generate it dynamically.Other changes:
REPL
).Markdown
syntax, as advised inJulia
's documentation.func(args..., kwargs...)
syntax.z
->A
inheatmap.jl
, sinceA
reflects a matrix structure by convention.I've carefully inspected the results of
help?> <function>
wherefunction
isscatterplot
,Plot
,barplot
,heatmap
, ... against master and this is either equivalent of way better structured, since the arguments now follow a fixed order. We can fine tune each function arguments by givingdesc
,add
, orremove
keywords for the addedarguments
orsignature
functions.README.md
automaticallyI'm guessing that the runtime generation of docstrings only affects precompilation ofUnicodeplots
and not load time, but I'm not sure of that.Unexpected, and this looks bad:PRmaster@johnnychen94, do you have any obvious idea why this happens ?EDIT: sorry for the noise, the increased load time was just the effect of adding
Contour
dependency and thus loadingStaticArrays
.