Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Worker: stop listening after connection #42

Merged
merged 2 commits into from Mar 13, 2023
Merged

Worker: stop listening after connection #42

merged 2 commits into from Mar 13, 2023

Conversation

fonsp
Copy link
Member

@fonsp fonsp commented Mar 13, 2023

Implement #41

Cool! We actually didn't need that while loop and the InterruptException handler :)

@fonsp fonsp changed the base branch from main to reuse-connection March 13, 2023 10:16
@fonsp
Copy link
Member Author

fonsp commented Mar 13, 2023

I was hoping that this would also give a workaround for JuliaLang/julia#37154 since it avoids the try-inside-while from the issue's MWE... but nope. You can still see it in the failing CI log

@fonsp fonsp linked an issue Mar 13, 2023 that may be closed by this pull request
Stop listening when TCP connection is established? #41
Closed
@fonsp fonsp merged commit 48dfa9f into reuse-connection Mar 13, 2023
12 of 13 checks passed
@fonsp fonsp deleted the reuse-connection-stop-listening branch March 13, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop listening when TCP connection is established?
1 participant
@fonsp