Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that parsedcode is of type Expr #10

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Make sure that parsedcode is of type Expr #10

wants to merge 3 commits into from

Conversation

JackDevine
Copy link

Fixes #8

Sorry for the delay and thanks again for your advice in the linked issue.

fonsp
fonsp requested changes Mar 28, 2024
View reviewed changes
src/TopologyUpdate.jl Show resolved Hide resolved
@JackDevine
Copy link
Author

Thanks for making those changes @fonsp ! Doing a few local tests, I can see that the results are different if you always wrap the expressions.

Do you think that the CI failures on Julia latest are unrelated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fonsp fonsp fonsp requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loosen requirement that parsed code is of type Expr
2 participants
@JackDevine @fonsp