Force an old version of the Kaleido C library for windows tests #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 88.62% 89.41% +0.78%
==========================================
Files 12 12
Lines 255 255
==========================================
+ Hits 226 228 +2
+ Misses 29 27 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that many people face problems with kaleido on windows hanging:
The suggestion in the issues in the main Kaleido repository above was to downgrade the kaleido library to 0.1 in windows to make this work, and preliminary tests seem to validate this also from Julia.
It is not necessary to downgrade PlotlyKaleido itself, but is sufficient to introduce in the Project/environment the Kaleido_jll package tagged to the 0.1 version.
This seems to fix the tests and should also be a way of fixing the PlotlyKaleido library on windows machines