You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If a user explicitly sets $PYTHON then it means s/he do not want auto-magical handling of Python packages by Conda.jl. Installing package automatically at runtime is not what programmers would expect, I hope (unless, say, there is some integrity check like GPG verification). I can think of several options to fix it:
Let CONDA_JL_HOME handle this case and remove this if !isempty(aconda) branch.
Print an error message with instruction to install appropriate packages.
If isinteractive() then prompt user before executing conda install.
If you are going to take an option like 3, I think there is one more thing to be fixed:
I propose to stop unconditionally installing conda packages in
pyimport_conda
when Conda.jl is not used:PyCall.jl/src/PyCall.jl
Lines 657 to 663 in 49029e0
If a user explicitly sets
$PYTHON
then it means s/he do not want auto-magical handling of Python packages by Conda.jl. Installing package automatically at runtime is not what programmers would expect, I hope (unless, say, there is some integrity check like GPG verification). I can think of several options to fix it:CONDA_JL_HOME
handle this case and remove thisif !isempty(aconda)
branch.isinteractive()
then prompt user before executingconda install
.If you are going to take an option like 3, I think there is one more thing to be fixed:
PyCall.jl/src/PyCall.jl
Lines 662 to 663 in 49029e0
I don't think any package should modify user's configuration silently. Why not use
conda install --channel $channel ...
like this?:The text was updated successfully, but these errors were encountered: