Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Qt6 support to pygui #1002

Merged
merged 1 commit into from Aug 20, 2022
Merged

Add Qt6 support to pygui #1002

merged 1 commit into from Aug 20, 2022

Conversation

jamesjhu
Copy link
Contributor

Support discovery for PyQt6 and PySide6 in pygui().

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2022

Codecov Report

Merging #1002 (9839383) into master (b27bd5a) will decrease coverage by 0.26%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1002      +/-   ##
==========================================
- Coverage   68.36%   68.09%   -0.27%     
==========================================
  Files          20       20              
  Lines        2023     2031       +8     
==========================================
  Hits         1383     1383              
- Misses        640      648       +8     
Flag Coverage Δ
unittests 68.09% <0.00%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/gui.jl 0.00% <0.00%> (ø)
src/PyCall.jl 70.69% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@stevengj
Copy link
Member

LGTM.

@stevengj stevengj merged commit d5d3d07 into JuliaPy:master Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants