Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove const declaration in @pydef which is deprecated in local scope #571

Merged
merged 1 commit into from
Sep 17, 2018

Conversation

marius311
Copy link
Contributor

@marius311 marius311 commented Sep 17, 2018

@pydef declares the class const which if done in the local scope is deprecated in 0.7 / errors on 1.0. I just removed the const. I suppose it could still remain there in the global scope, which would offer slightly better type-stability / performance, but if you're building / calling into a Python class I would argue the overhead is likely to be insignificant in most cases.

@stevengj
Copy link
Member

I guess you can still do

const MyClass = PyCall.@pydef_object ....

but in a module setting I guess you couldn't define this as a const global anyway because it wouldn't be precompile-safe.

@stevengj stevengj merged commit 28f75b0 into JuliaPy:master Sep 17, 2018
@marius311 marius311 deleted the remove_const branch September 17, 2018 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants