Add weakref support for pyjlwrap types #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have added [weak reference support][1] for `pyjlwrap` types, following the documentation for Python 3+. Adding weak reference support for Python 2.x seems much the same as in 3.x, however 3.x does not use Py_TPFLAGS_HAVE_WEAKREFS, which also does not seem necessary for 2.x. Simple testing suggests that this is working as expected. Closes JuliaPy#21, JuliaPy#158 [1]: https://docs.python.org/3/extending/newtypes.html#weak-reference-support
|
The HAVE_WEAKREFS flag is not needed since it is part of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added weak reference support for
pyjlwraptypes, following thedocumentation for Python 3+. Adding weak reference support for Python 2.x seems
much the same as in 3.x, however 3.x does not use Py_TPFLAGS_HAVE_WEAKREFS,
which also does not seem necessary for 2.x. Simple testing suggests that this is
working as expected.
Closes JuliaPy/PyPlot.jl#21
Closes #158