give pytype_mapping precendence over default mappings #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey guys, can you take a look at this? I think this is right, and the current behavior is problematic. |
|
LGTM. |
|
Awesome, thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial fix to give the user-specified
pytype_mappings precedence over the default built-ins, such that things which subclass Pythonarray,dict, etc... can have custom mappings in PyCall.@stevengj mentions in #700 (comment) that you're trying to move away from needing these conversions at all, but given that its a year later and we're still not quite there, I think this is still useful in the meantime.
Closes #751, #700