-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix getproperty exceptions #997
Conversation
Codecov Report
@@ Coverage Diff @@
## master #997 +/- ##
==========================================
- Coverage 68.36% 68.35% -0.02%
==========================================
Files 20 20
Lines 2023 2038 +15
==========================================
+ Hits 1383 1393 +10
- Misses 640 645 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bump |
Looks good, modulo a couple of minor tweaks noted above. |
I also pushed the corresponding setproperty fix, if you know the proper way to check the exception please update it as well! For now, getproperty tests fail with your changes. |
What is |
In the two corresponding cases, it's: e.T = PyObject <class 'ValueError'>
# and
e.T = PyObject <class 'AttributeError'> |
What does |
Oh, I see the problem. if PyPtr(e.T) != @pyglobalobjptr(:PyExc_AttributeError) (The goal here is to avoid the string conversion. Also, checking whether it is actually |
this throws KeyError as before when the attribute isn't there (AttributeError in python)
when the attribute is present, but its computation throws a python exception, this PR rethrows it in julia
fixes #696