Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase of #445 #515

Merged
merged 4 commits into from Nov 23, 2022
Merged

Rebase of #445 #515

merged 4 commits into from Nov 23, 2022

Conversation

mkitti
Copy link
Member

@mkitti mkitti commented Nov 21, 2022

I rebased #445

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 87.23% // Head: 87.23% // No change to project coverage 👍

Coverage data is based on head (37bbded) compared to base (6b8c10d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #515   +/-   ##
=======================================
  Coverage   87.23%   87.23%           
=======================================
  Files          39       39           
  Lines        2342     2342           
=======================================
  Hits         2043     2043           
  Misses        299      299           
Impacted Files Coverage Δ
src/julia/tools.py 77.77% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@MilesCranmer MilesCranmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mkitti mkitti merged commit 1e3de7b into JuliaPy:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants