-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiplication fix. #39
Conversation
Well spotted! Could you add a test for this case? (I guess something like |
@acroy tests added and squashed. Ready to be merged ! |
@@ -11,6 +11,7 @@ qv = QuArray(v) | |||
@assert rawcoeffs(qm'*qm') == m*m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh, I guess all of those should be coeffs
rather than rawcoeffs
? This would probably also cover the new test case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rawcoeffs
and coeffs
return the same for all the cases except for the recent commit. @acroy please do let me know if am missing something further here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, although we probably could/should consistently use coeffs
everywhere (unless we really mean rawcoeffs
).
4e22a62
to
ee2301f
Compare
@acroy I hope this is ready. |
Fix multiplication of QuMatrix and DualMatrix. Tests updated.
The following case fails
the last one has to be