Skip to content
This repository has been archived by the owner on Aug 21, 2020. It is now read-only.

RFC: README.md, WIP: REQUIRE #1

Merged
merged 1 commit into from
May 20, 2015

Conversation

amitjamadagni
Copy link
Member

Updated README.md. Added REQUIRE file, QuBase needs to be added, which needs to be registered. Any pointers on this would be helpful.

Edit : Related PR JuliaLang/julia#7737, I guess we could register QuBase.jl as I guess there is no support for links in REQUIRE.

@acroy
Copy link
Contributor

acroy commented May 18, 2015

I guess it will take some more work before we register QuBase.jl. I would just state in the README that one needs to clone this repo and QuBase.jl to get started.

@amitjamadagni
Copy link
Member Author

@acroy I hope this is fine. Please do let me know if this can be merged.


This has to be added using
```julia
julia>Pkg.clone([https://github.com/JuliaQuantum/QuBase.jl](https://github.com/JuliaQuantum/QuBase.jl))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably slipped in when copying. You only need Pkg.clone("https://github.com/JuliaQuantum/QuBase.jl.git") and similarly for QuDynamics below (you can find the clone URL in github on the right side of the project pages).

I would also remove "julia>" since this is clear.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! I was trying to provide the link which seems to be wrong. Anyways edits done. Sorry for that I overlooked it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not putting the commands in quotes with ` or ```?

@acroy
Copy link
Contributor

acroy commented May 20, 2015

I think it is fine and I guess you can merge it yourself, right?

@amitjamadagni
Copy link
Member Author

Yeah I can merge this

@acroy
Copy link
Contributor

acroy commented May 20, 2015

Go for it :-)

amitjamadagni added a commit that referenced this pull request May 20, 2015
RFC: README.md, WIP: REQUIRE
@amitjamadagni amitjamadagni merged commit d055d9c into JuliaQuantum:master May 20, 2015
@amitjamadagni amitjamadagni deleted the updates branch May 23, 2015 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants