Add Amplitudes and PulseParametrizations
#46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should enable pulse parametrization in GRAPE (not tested) |
goerz
added a commit
to JuliaQuantumControl/Krotov.jl
that referenced
this pull request
Oct 28, 2022
This removes the old `PulseParametrization` and its initializers `SquareParametrization`, `TanhParametrization`, `TanhSqParametrization`, `LogisticParametrization`, `LogisticSqParametrization`. These have been moved to `QuantumControlBase` in a modified form, see JuliaQuantumControl/QuantumControlBase.jl#46 The parametrization example is updated to use the the new `ParametrizedAmplitude`.
This was referenced Oct 28, 2022
Merged
goerz
added a commit
to JuliaQuantumControl/Krotov.jl
that referenced
this pull request
Oct 28, 2022
This removes the old `PulseParametrization` and its initializers `SquareParametrization`, `TanhParametrization`, `TanhSqParametrization`, `LogisticParametrization`, `LogisticSqParametrization`. These have been moved to `QuantumControlBase` in a modified form, see JuliaQuantumControl/QuantumControlBase.jl#46 The parametrization example is updated to use the the new `ParametrizedAmplitude`.
goerz
added a commit
to JuliaQuantumControl/Krotov.jl
that referenced
this pull request
Oct 28, 2022
This removes the old `PulseParametrization` and its initializers `SquareParametrization`, `TanhParametrization`, `TanhSqParametrization`, `LogisticParametrization`, `LogisticSqParametrization`. These have been moved to `QuantumControlBase` in a modified form, see JuliaQuantumControl/QuantumControlBase.jl#46 The parametrization example is updated to use the the new `ParametrizedAmplitude`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements non-trivial control amplitudes such as
LockedAmplitude,ShapedAmplitude,ParametrizedAmplitude. The latter allows for a more general implementation of pulse parametrization, e.g.SquareParametrization,TanhParametrization,TanhSqParametrization,LogisticParametrization,LogisticSqParametrization. These have been brought over from the Krotov package. However, the concept is now rephrased fromϵ(u(t)toa(ϵ(t). Thus, the fields ofPulseParametrizationhave changed names accordingly.