Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise option output_function #468

Open
schillic opened this issue Feb 17, 2019 · 2 comments
Open

Revise option output_function #468

schillic opened this issue Feb 17, 2019 · 2 comments

Comments

@schillic
Copy link
Member

Internally, we create the option :output_function. It can either be nothing or a matrix, say, A. In the latter case, before we store the reachset X, we apply a box approximation to the set A * X.
I would rename the option (nobody would expect that behavior from the name output_function 😄) and refactor it out of the actual reachability code. This is a typical post-processing task.

@mforets
Copy link
Member

mforets commented Feb 18, 2019

Yes, i agree to refactor that code out of the reachability code. We can use a system with output to substitute :output_function and do the post-processing.

@schillic
Copy link
Member Author

I changed my mind here. This is probably the only way to support lazy flowpipes with lazy inputs. So it makes sense to keep it. However, it currently crashes during projection, so this needs to be revised. The option should probably be renamed and become an input option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants