Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop ignoring stdlibs #457

Merged
merged 3 commits into from Oct 26, 2023
Merged

Stop ignoring stdlibs #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59d0f05
Stop ignoring stdlibs
DilumAluthge Oct 14, 2023
ab0b827
Update some tests (#459)
DilumAluthge Oct 26, 2023
a339fe9
Update another test
DilumAluthge Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/dependencies.jl
View file
Open in desktop
Expand Up @@ -29,9 +29,9 @@ function get_project_deps(project_file::AbstractString; include_jll::Bool=false)
name = dep[1]
uuid = UUIDs.UUID(dep[2])

# Ignore STDLIB packages and JLL ones if flag set
if !Pkg.Types.is_stdlib(uuid) &&
(!endswith(lowercase(strip(name)), "_jll") || include_jll)
# Ignore JLL packages if flag set
# Do NOT ignore stdlib packages.
if !endswith(lowercase(strip(name)), "_jll") || include_jll
package = Package(name, uuid)
compat_entry = DepInfo(package)
dep_entry = convert(String, strip(get(compat, name, "")))
Expand Down
4 changes: 2 additions & 2 deletions test/dependencies.jl
View file
Open in desktop
Expand Up @@ -15,9 +15,9 @@ end
project = joinpath(@__DIR__, "deps", "Project.toml")

deps = CompatHelper.get_project_deps(project; include_jll=true)
@test length(deps) == 2
@test length(deps) == 3
deps = CompatHelper.get_project_deps(project; include_jll=false)
@test length(deps) == 1
@test length(deps) == 2
end

@testset "clone_all_registries" begin
Expand Down
4 changes: 2 additions & 2 deletions test/main.jl
View file
Open in desktop
Expand Up @@ -62,7 +62,7 @@
"GITHUB_REPOSITORY" => "CompatHelper.jl", "GITHUB_TOKEN" => "token"
) do
prs = CompatHelper.main()
@test length(prs) == 1
@test length(prs) == 2
@test prs[1] isa GitHub.PullRequest
end
end
Expand Down Expand Up @@ -96,7 +96,7 @@
) do
delete!(ENV, "GITHUB_REPOSITORY")
prs = CompatHelper.main()
@test length(prs) == 1
@test length(prs) == 2
@test prs[1] isa GitLab.MergeRequest
end
end
Expand Down