-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No warning for meaningless compat entry #7146
Comments
There was no warning because there was no such compat entry. If you look at https://github.com/JuliaRegistries/General/pull/7046/files, you see that no new compat entry was added for So why would there be any warning? Unless I am misunderstanding, there is nothing to warn about. |
This might actually belong the the JuliaRegistrator repo. There should be a warning in the resulting GitHub comment or PR even though it doesn't make it into the code changes of the PR itself. |
I took another look at your Project.toml file. You have a compat entry for JSExpr. However, JSExpr is listed as a test-dependency. It is perfectly normal to have compat entries for test-dependencies. So I’m not sure Registrator would throw a warning either. |
But information about test-dependencies is never put into the General registry. So this all seems like the normal expected behavior. |
Bleh you are indeed correct. WebIO's tests are in general not great™ with lots of reverse dependencies. Thanks for your time and I suppose this can be closed. |
#7046
To register WebIO v0.8.13 (lucky number 13!), I added JSExpr to the compat because I was trying to fix an issue where JSExpr v1 has just been released and was incompatible.
The merge bot yelled at me because I didn't have compat for other things so I decided to also add everything else. However, it looks like when I re-triggered the merge bot, it lost the compat entry for JSExpr?JSExpr v0.5 depends on WebIO, but in v1.0, we dropped the dependency (and were planning on reversing it for WebIO v1.0). I forgot that WebIO doesn't actually depend on JSExpr though when I added the compat entry.
The registrator bot should probably(?) yell at me because JSExpr is not a dependency of WebIO (which I discovered with #7145).
The text was updated successfully, but these errors were encountered: