-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WebIO's compat for JSExpr #7145
Conversation
I'm not 100% on the version specification format here. My understanding is that `0.5` means `[0.5.0, 0.6)`. Please merge ASAP if looks good. :^)
Is there any way to resolve this issue? Does Pkg allow circular dependencies? :^) Another "solution" might be to un-release JSExpr v1.0 since it was only really released in preparation for WebIO v1.0 (these issues would still exist but they wouldn't be as bad because someone installing JSExpr and WebIO from scratch would get the latest versions that work with each other). |
No. |
What are you trying to accomplish here? |
JSExpr depended upon WebIO but that was kind of bad™ so we removed the dependency in v1 and were going to have WebIO depend on JSExpr to implement some webio-specific functionality in WebIO v1 (but that's a WIP). As it stands, because we reversed the direction of the dependency, we can't constraint what version of JSExpr gets installed. |
This can’t be merged in its current state because it is causing CI to fail. I’m not sure this is the correct way to fix this situation. Perhaps one of @fredrikekre @KristofferC @StefanKarpinski can help out with this after the holidays. |
Yeah, I made this PR thinking that WebIO depended on JSExpr and then figuring out that we're in the current situation. :^) One solution would be to allow "peer dependency" specifications (à la "A doesn't depend on B, but if B is installed it must be version v1.2.3") but that's a structural change to the Pkg system and I have a feeling that it wouldn't be well received by most (for probably pretty valid reasons). I suspect that the immediate fix would be to yank JSExpr v1 for now and un-yank them once we we have WebIO v1.0 ready to go. There would still be some of these issues but at least |
If the issue here is that you made a bad release of |
Just be aware that you cannot “unyank” a release. So if you released 1.0 and now you want to yank it, you can yank 1.0, but you can’t later unyank it. You can however make a new release, e.g. 1.1 or 2.0. |
I think the correct solution here is for you to yank The solution definitely isn’t to add all of these dependencies retroactively, so I’m closing this PR. |
I'm not 100% on the version specification format here. My understanding is that
0.5
means[0.5.0, 0.6)
.Please merge ASAP if looks good. :^)