Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: SossMLJ v0.1.0 #21452

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: cf2dc0df-ab57-42da-b773-28c60db69bd5
Repo: https://github.com/cscherrer/SossMLJ.jl.git
Tree: 96f4d4a10e55f1ca7ce3ca14d77283b29f83ddc0

Registrator tree SHA: e934b8c55381f28735124f23e8f7e96d09b20416
@DilumAluthge
Copy link
Member

[noblock]

cc: @cscherrer @ablaom @tlienart

@DilumAluthge
Copy link
Member

[noblock]

Does anyone object to me merging this before the waiting period has completed? This package integrates the Soss.jl probabilistic programming language into the MLJ.jl machine learning framework, so SossMLJ.jl is the most logical choice for a name.

@github-actions
Copy link
Contributor

Your new package pull request met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

Since you are registering a new package, please make sure that you have read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@ablaom
Copy link
Contributor

ablaom commented Sep 15, 2020

[noblock]

Mmm. I'm assuming there's a reason you don't include the implementation of the MLJ interface in Soss.jl itself?

At present we do have interfaces that live outside the algorithm-providing package, but the convention for naming is different. For example, we have MLJScikitLearnInterface and will soon have others like MLJMultivariateStatsInterface (see the MLJModels "disintegration" issue). (I admit there is one exception to this rule MLJFlux.)

@DilumAluthge
Copy link
Member

DilumAluthge commented Sep 15, 2020

[noblock]

Yep, SossMLJ needs some stuff from MLJBase, so it's a little heavier than the average MLJ integration. That's why we decided to keep it in its own package.

I don't feel too strongly about the name. We could also do MLJSoss.

MLJSossInterface feels a little too verbose? But we could do that also.

The Soss+Gen integration is being worked on in https://github.com/cscherrer/SossGen.jl, so SossMLJ is consistent with SossGen.

@cscherrer Any thoughts?

@cscherrer
Copy link

cscherrer commented Sep 16, 2020

[noblock]

I'm not sure if there's a general rule for interfaces across platforms, and this seems to me more Soss-specific than MLJ-specific - much less plug-and-play than most MLJ models. I do like the idea of easy discoverability by tab completion, for the future situation of someone developing models in Soss looking for more opportunities to use it.

@DilumAluthge
Copy link
Member

[noblock]

Another consideration is that we are probably going to disintegrate Soss into multiple smaller packages, including:

  • Soss
  • SossBase
  • SossSymPy - we'll be factoring the Python out into this package
  • SossMLJ

@ablaom
Copy link
Contributor

ablaom commented Sep 16, 2020

[noblock]

Don't have any strong objections to any of the suggested names. My comment was just for context.

@ablaom
Copy link
Contributor

ablaom commented Sep 16, 2020

[noblock]

MLJ users won't have problem finding it because it will be in the model registry; the package_name assigned will be Soss (unless there is some reason not to) and a separate trait load_path links to the package with the interface.

@DilumAluthge DilumAluthge merged commit af35773 into master Sep 16, 2020
@DilumAluthge DilumAluthge deleted the registrator/sossmlj/cf2dc0df/v0.1.0 branch September 16, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants