-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: SossMLJ v0.1.0 #21452
New package: SossMLJ v0.1.0 #21452
Conversation
JuliaRegistrator
commented
Sep 15, 2020
- Registering package: SossMLJ
- Repository: https://github.com/cscherrer/SossMLJ.jl
- Created by: @DilumAluthge
- Version: v0.1.0
- Commit: aec0583d143a83d118194bc258d80c876223b3c3
- Reviewed by: @DilumAluthge
- Reference: cscherrer/SossMLJ.jl@aec0583#commitcomment-42345391
UUID: cf2dc0df-ab57-42da-b773-28c60db69bd5 Repo: https://github.com/cscherrer/SossMLJ.jl.git Tree: 96f4d4a10e55f1ca7ce3ca14d77283b29f83ddc0 Registrator tree SHA: e934b8c55381f28735124f23e8f7e96d09b20416
[noblock] |
[noblock] Does anyone object to me merging this before the waiting period has completed? This package integrates the |
Your Since you are registering a new package, please make sure that you have read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1 If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text |
[noblock] Mmm. I'm assuming there's a reason you don't include the implementation of the MLJ interface in Soss.jl itself? At present we do have interfaces that live outside the algorithm-providing package, but the convention for naming is different. For example, we have |
[noblock] Yep, I don't feel too strongly about the name. We could also do
The Soss+Gen integration is being worked on in https://github.com/cscherrer/SossGen.jl, so @cscherrer Any thoughts? |
[noblock] I'm not sure if there's a general rule for interfaces across platforms, and this seems to me more Soss-specific than MLJ-specific - much less plug-and-play than most MLJ models. I do like the idea of easy discoverability by tab completion, for the future situation of someone developing models in Soss looking for more opportunities to use it. |
[noblock] Another consideration is that we are probably going to disintegrate
|
[noblock] Don't have any strong objections to any of the suggested names. My comment was just for context. |
[noblock] MLJ users won't have problem finding it because it will be in the model registry; the |