Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: WebSockets v1.5.9 #28608

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Conversation

JuliaRegistrator
Copy link
Contributor

Revert to reading a minimum of two bytes. Skip v1.5.8 because it's already tagged in git.

UUID: 104b5d7c-a370-577a-8038-80a2059c5097
Repo: https://github.com/JuliaWeb/WebSockets.jl.git
Tree: f91a602e25fe6b89afc93cf02a4ae18ee9384ce3

Registrator tree SHA: e934b8c55381f28735124f23e8f7e96d09b20416
JuliaRegistrator referenced this pull request in JuliaWeb/WebSockets.jl Jan 25, 2021
@JuliaRegistrator register()

Release notes:

Revert to reading a minimum of two bytes. Skip version 1.5.8 because the github tag exists.
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch January 25, 2021 13:02 Inactive
@github-actions
Copy link
Contributor

Your new version pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README. The following guidelines were not met:

  • Does not meet sequential version number guideline: version 1.5.9 skips over 1.5.8

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

After you have fixed the AutoMerge issues, simple retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number).

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@giordano
Copy link
Member

@hustf ☝️

@hustf
Copy link

hustf commented Jan 25, 2021

[noblock]
Hi, still not used to the procedure with attobot and registrator. So I triggered attobot prior to registrator. Skipping a number preserves git history and is the best solution.

@giordano
Copy link
Member

Just don't use attobot (didn't even know it still works). TagBot will create the release for you

@giordano giordano merged commit 5e175a4 into master Jan 25, 2021
@giordano giordano deleted the registrator/websockets/104b5d7c/v1.5.9 branch January 25, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants