Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: Persa v0.1.2 #4401

Merged
1 commit merged into from
Oct 28, 2019
Merged

New version: Persa v0.1.2 #4401

1 commit merged into from
Oct 28, 2019

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Oct 15, 2019

  • New operations with ratings

@fredrikekre
Copy link
Member

fredrikekre commented Oct 16, 2019

Please add (at least)

[compat]
julia = "1"

to your project file and retrigger the bot.

[noblock]

@ghost
Copy link

ghost commented Oct 17, 2019

Your new version pull request does not meet all of the guidelines for automatic merging.

Specifically, your pull request does not meet the following guidelines:

  • The following dependencies do not have a compat entry that has an upper bound: DataFrames

It is important to note that if your pull request does not meet the guidelines for automatic merging, this does not mean that your pull request will never be merged. It just means that your pull request will require manual review by a human.

These guidelines are intended not as requirements for packages but as very conservative guidelines, which, if your new package or new version of a package meets them, it may be automatically merged.


On a separate note, I see that you are registering a release with a version number of the form v0.X.Y.

Does your package have a stable public API? If so, then it's time for you to register version v1.0.0 of your package. (This is not a requirement. It's just a recommendation.)

If your package does not yet have a stable public API, then of course you are not yet ready to release version v1.0.0.


[noblock]

UUID: 86800b63-3017-5277-aca5-15d7d6a5f2b2
Repo: https://github.com/JuliaRecsys/Persa.jl.git
Tree: 71e2e2c045bd63789d64014e9df5e4fcace666f2

Registrator tree SHA: f50e50c1d2a1b9694b1d5749fdb25fef2ca4c291
JuliaRegistrator referenced this pull request in JuliaRecsys/Persa.jl Oct 27, 2019
@ghost
Copy link

ghost commented Oct 27, 2019

Your new version pull request met all of the guidelines for automatic merging.

I will automatically merge this pull request during the next cron job.

If you want to prevent this pull request from being auto-merged, simply leave a comment.

(If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.)


On a separate note, I see that you are registering a release with a version number of the form v0.X.Y.

Does your package have a stable public API? If so, then it's time for you to register version v1.0.0 of your package. (This is not a requirement. It's just a recommendation.)

If your package does not yet have a stable public API, then of course you are not yet ready to release version v1.0.0.


[noblock]

@ghost ghost merged commit 54f68dc into master Oct 28, 2019
@ghost ghost deleted the registrator/persa/86800b63/v0.1.2 branch October 28, 2019 09:02
@julia-tagbot
Copy link

julia-tagbot bot commented Oct 28, 2019

I've created release v0.1.2, here it is.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants