-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: Signatures v0.1.0 #4907
Conversation
JuliaRegistrator
commented
Oct 30, 2019
•
edited
edited
- Registering package: Signatures
- Repository: https://github.com/PeaceFounder/CryptoSignatures.jl
- Created by: @Akels
- Version: v0.1.0
- Commit: b61c26603bdd20055ee9d7390dbe84e7b4070208
- Reviewed by: @Akels
- Reference: PeaceFounder/CryptoSignatures.jl@b61c266#commitcomment-35770978
Your
Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text |
Maybe Also, if you add the compatibiltiiy bounds this PR will be merged automatically. [noblock] |
The name is indeed generic. Currently, I can think of two examples which user might think about what Signatures does:
On the other hand, I think the second option does dominate. Also, the library intends to cover the case of ring signatures which does not pop out in google easily when searches for electronic signatures. |
How about:
Personally I like That being said, I don't mind [noblock] |
I like DigitalSignatures and CryptoSingatures. I think I will change the name. |
UUID: df5a2326-c3ea-4184-be62-c9e79f43451b Repo: https://github.com/PeaceFounder/CryptoSignatures.jl.git Tree: 6bd34308d325d50a77048c17e6a61592f47bcece Registrator tree SHA: f50e50c1d2a1b9694b1d5749fdb25fef2ca4c291
cdae2d3
to
e013d87
Compare
Your
Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text |
I just changed the name and updated pull request. Do I need to worry about:
|
This is due to a bug in Registrator.jl: JuliaRegistries/Registrator.jl#236 I will close this pull request. Can you re-trigger Registrator? This will open a new pull request with the correct pull request title corresponding to your new package name. Also, if you can add compat entries (with upper bounds) for Nettle and Paillier, then your PR will be automerged. |
But I don't know the future. How can I add upper bounds? |