Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Signatures v0.1.0 #4907

Closed

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Oct 30, 2019

JuliaRegistrator referenced this pull request in PeaceFounder/CryptoSignatures.jl Oct 30, 2019
@github-actions
Copy link
Contributor

Your new package pull request does not meet the following guidelines for auto-merging:

  • The following dependencies do not have a compat entry that has an upper bound: Nettle, Paillier

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@fredrikekre
Copy link
Member

Maybe ElectronicSignatures is a less generic and more descriptibe name? Just a suggestion.

Also, if you add the compatibiltiiy bounds this PR will be merged automatically.

[noblock]

@JanisErdmanis
Copy link

JanisErdmanis commented Oct 31, 2019

The name is indeed generic. Currently, I can think of two examples which user might think about what Signatures does:

  • some processing with type signatures
  • the electronic signatures from cryptography

On the other hand, I think the second option does dominate. Also, the library intends to cover the case of ring signatures which does not pop out in google easily when searches for electronic signatures.

@DilumAluthge
Copy link
Member

DilumAluthge commented Nov 1, 2019

How about:

  • DigitalSignatures
  • ElectronicSignatures
  • CryptoSignatures
  • CryptographicSignatures

Personally I like DigitalSignatures the best.

That being said, I don't mind Signatures as a name.

[noblock]

@JanisErdmanis
Copy link

I like DigitalSignatures and CryptoSingatures. I think I will change the name.

UUID: df5a2326-c3ea-4184-be62-c9e79f43451b
Repo: https://github.com/PeaceFounder/CryptoSignatures.jl.git
Tree: 6bd34308d325d50a77048c17e6a61592f47bcece

Registrator tree SHA: f50e50c1d2a1b9694b1d5749fdb25fef2ca4c291
@JuliaRegistrator JuliaRegistrator force-pushed the registrator/signatures/df5a2326/v0.1.0 branch from cdae2d3 to e013d87 Compare November 1, 2019 22:23
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2019

Your new package pull request does not meet the following guidelines for auto-merging:

  • Repo URL does not end with /name.jl.git, where name is the package name
  • The following dependencies do not have a compat entry that has an upper bound: Nettle, Paillier

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@JanisErdmanis
Copy link

I just changed the name and updated pull request. Do I need to worry about:

Repo URL does not end with /name.jl.git, where name is the package name

@DilumAluthge
Copy link
Member

This is due to a bug in Registrator.jl: JuliaRegistries/Registrator.jl#236

I will close this pull request. Can you re-trigger Registrator? This will open a new pull request with the correct pull request title corresponding to your new package name.

Also, if you can add compat entries (with upper bounds) for Nettle and Paillier, then your PR will be automerged.

@JanisErdmanis
Copy link

But I don't know the future. How can I add upper bounds?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants