Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yank ProgressMeterLogging.jl #5000

Closed
wants to merge 1 commit into from
Closed

Conversation

tkf
Copy link
Contributor

@tkf tkf commented Nov 3, 2019

close #4917

As I mentioned in #4917, I renamed ProgressMeterLogging.jl to ConsoleProgressMonitor.jl so I would like to make ProgressMeterLogging.jl uninstallable. From the discussion in #4917, it seems yanking is the best approach, IIUC.

@fredrikekre
Copy link
Member

Have you tried out what happens? I have only tested yanking when there were other releases left.

@tkf
Copy link
Contributor Author

tkf commented Nov 7, 2019

So it seems that this breaks resolve (which I expected to work):

$ cd $(mktemp -d)
...

$ jlpkg --project=. add ProgressMeterLogging
...

$ git checkout tkf/patch-1
...

$ jlpkg --project=. resolve
 Resolving package versions...
ResolverError: Unsatisfiable requirements detected for package ProgressMeterLogging [b0e84e9e]:
 ProgressMeterLogging [b0e84e9e] log:
 ├─ProgressMeterLogging [b0e84e9e] has no known versions!
 └─restricted to versions 0.1.0 by an explicit requirement — no versions left

Instantiation works, though:

$ mkdir -p depot/registries

$ ln -s ~/.julia/registries/General depot/registries

$ JULIA_DEPOT_PATH=$PWD/depot jlpkg --project=. instantiate
 Installed LoggingExtras ──────── v0.3.0
 Installed ProgressMeter ──────── v1.1.0
 Installed ProgressMeterLogging ─ v0.1.0

$ ls depot/packages
LoggingExtras  ProgressMeter  ProgressMeterLogging

@fredrikekre
Copy link
Member

Ok, I feel like that should maybe work. Can you open an issue on Pkg?

@tkf
Copy link
Contributor Author

tkf commented Nov 8, 2019

I opened an issue in Pkg.jl. I'll close this as it's not super important compared to the possibility of breaking things in older julia/Pkg (even though I guess this won't happen in practice).

@tkf tkf closed this Nov 8, 2019
@tkf tkf deleted the patch-1 branch November 8, 2019 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What to do after renaming a package?
2 participants