Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bounds to BangBang/Compat.toml #5098

Merged
merged 2 commits into from
Nov 7, 2019
Merged

Conversation

tkf
Copy link
Contributor

@tkf tkf commented Nov 5, 2019

This patch adds (upper) bounds to BangBang/Compat.toml so that old versions will not be installed in the future when the latest versions do not support some set of upstream versions. (As discussed in https://discourse.julialang.org/t/backpropagate-compat-bounds/30737/5)

I tried to mimic how Compat.toml is "compressing" the bounds but I'm not sure if I did it correctly. Would RegistryCI find incorrect bound specification?

@fredrikekre
Copy link
Member

fredrikekre commented Nov 7, 2019

Would RegistryCI find incorrect bound specification?

It checks that Pkg can actually read the bounds, but not if they "make sense".

Edit: Needs a rebase.

@tkf
Copy link
Contributor Author

tkf commented Nov 7, 2019

Thanks. I resolved the conflict.

but not if they "make sense"

I think it would be nice if the CI can check that the compat bound is not tightened than the existing versions (i.e., it's "no-op"). Is it hard to verify this? If I were to feature request it, should it go to RegistryCI.jl? Or maybe to Pkg.jl to add some kind of Pkg.Registry.* API to create the correct Compat.toml in the first place?

@fredrikekre fredrikekre merged commit ab9b815 into JuliaRegistries:master Nov 7, 2019
@fredrikekre
Copy link
Member

We should probably have a package/repo for modification of registry files. Right now it is split up over Pkg/bin and Registrator, but neither place is a good fit IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants