Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: PowerModelsAnnex v0.2.6 #6708

Merged
merged 1 commit into from
Dec 21, 2019

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Dec 14, 2019

@github-actions
Copy link
Contributor

Your new version pull request does not meet the following guidelines for auto-merging:

  • The following dependencies do not have a compat entry that has an upper bound: Unitful

Note: If your package works for the current version x.y.z of a dependency foo, then a compat entry foo = x.y.z implies a compatibility upper bound for packages following semver. You can additionally include earlier versionsyour package is compatible with. See [https://julialang.github.io/Pkg.jl/v1/compatibility/.] for details.

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@ccoffrin
Copy link

@DilumAluthge, I am confused by this feedback. As I understand the compat system, Unitful should have an UB of 1.0. See https://github.com/lanl-ansi/PowerModelsAnnex.jl/blob/master/Project.toml

@DilumAluthge
Copy link
Member

[noblock]

Unitful = ">= 0.7, < 1.0" means greater than or equal to 0.7 OR less than 1.0. So in fact this compat allows any version of Unitful.

@ccoffrin
Copy link

Ok, so what's the simplest way to encode ">= 0.7 AND < 1.0"?

@DilumAluthge
Copy link
Member

DilumAluthge commented Dec 14, 2019

Option 1: https://julialang.github.io/Pkg.jl/dev/compatibility/#Hyphen-specifiers-1

But this requires at least Julia 1.4. And AutoMerge runs on the latest release, which is Julia 1.3. So I wouldn’t recommend using hyphen specifiers until Julia 1.4 is released.

Option 2: just list out all of the breaking versions that you support, e.g. "0.7, 0.8, 0.9"

[noblock]

UUID: 6e471128-d39d-5672-b02b-a742bd1b77ed
Repo: https://github.com/lanl-ansi/PowerModelsAnnex.jl.git
Tree: 8b049c0c263d58a225278ec782754e24eaf9648f

Registrator tree SHA: f50e50c1d2a1b9694b1d5749fdb25fef2ca4c291
@JuliaRegistrator JuliaRegistrator force-pushed the registrator/powermodelsannex/6e471128/v0.2.6 branch from 4fb0f8f to 769b30a Compare December 20, 2019 17:45
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your new version pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@ccoffrin
Copy link

@DilumAluthge after being fixed this still seems to be missing the auto merge. Do you know what is up?

[noblock]

@DilumAluthge
Copy link
Member

If there are any comments on the pull request that don’t contain the text [noblock], then the automerge is blocked.

@DilumAluthge DilumAluthge merged commit 5bf1c2d into master Dec 21, 2019
@DilumAluthge DilumAluthge deleted the registrator/powermodelsannex/6e471128/v0.2.6 branch December 21, 2019 00:18
@julia-tagbot
Copy link

julia-tagbot bot commented Dec 21, 2019

I've created release v0.2.6, here it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants