reintroduce upper bounds to debugger stack #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfitzseb
reviewed
May 13, 2019
KristofferC
force-pushed
the
debugging_upper_bounds
branch
from
a3efc2e
to
2c3d62a
Compare
|
With big stacks we need better tools to make this less painful (JuliaRegistries/Registrator.jl#122), but this stack is short enough that it's basically a non-issue, and far better to have the bounds. |
|
Good to go? |
|
Yes, if you looked it over and think it seems reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These either didn't exist in the first place or were lost in the "normalization process" that ended up removing many upper bounds.