Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: NEOs v0.2.0 #71551

Merged
merged 1 commit into from
Nov 22, 2022
Merged

New package: NEOs v0.2.0 #71551

merged 1 commit into from
Nov 22, 2022

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: b41c07a2-2abb-11e9-070a-c3c1b239e7df
Repo: https://github.com/PerezHz/NEOs.jl.git
Tree: c5e9f69a6af1a1acb8d31abd7fa1551223d03b43

Registrator tree SHA: 8e1a5ac2695627143951512d700c7e3c445102ec
JuliaRegistrator referenced this pull request in PerezHz/NEOs.jl Nov 3, 2022
* Update Project.toml; remove Manifest.toml

* Update src/NEOs.jl

* Try another solution

* Update TT-TDB artifact

* Remove comment
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch November 3, 2022 10:08 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Your new package pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README and the AutoMerge guidelines. The following guidelines were not met:

  • Name is not at least 5 characters long
  • Package name similar to 2 existing packages.
    1. Similar to NES. Damerau-Levenshtein distance 2 is at or below cutoff of 2. Damerau-Levenshtein distance 1 between lowercased names is at or below cutoff of 1.
    2. Similar to NExOS. Damerau-Levenshtein distance 2 is at or below cutoff of 2. Damerau-Levenshtein distance 1 between lowercased names is at or below cutoff of 1.

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

After you have fixed the AutoMerge issues, simple retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number).

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged.

Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@PerezHz
Copy link

PerezHz commented Nov 3, 2022

We had previously attempted to register NEOs.jl (see #71434) and fixed most issues listed there. After addressing most of those, the only standing issue blocking auto-merging is the naming of the package, NEOs.jl, which we would like to ask to keep if possible, since it is an standard acronym for Near-Earth Objects in the field of Solar System Small Body science. Many thanks in advance!

cc: @lbenet

@lbenet
Copy link

lbenet commented Nov 8, 2022

Bump: any updates in our request for naming our package NEOs.jl and registering it?

cc @giordano

@lbenet
Copy link

lbenet commented Nov 18, 2022

Bump: any updates in our request for naming our package NEOs.jl and registering it?
cc: @DilumAluthge

@PerezHz
Copy link

PerezHz commented Nov 22, 2022

@lbenet: If the registration is taking too long maybe we can try to rename the package and then attempt re-registering?

@lbenet
Copy link

lbenet commented Nov 22, 2022

I'm open to that possibility, but it would be nice to know if this is the way to go, or who to contact to discuss this. Just to add a small argument in favor of the name NEOs.jl, this link to our paper where the software is mentioned: https://www.nature.com/articles/s43247-021-00337-x

@giordano giordano merged commit fc38ef8 into master Nov 22, 2022
@giordano giordano deleted the registrator/neos/b41c07a2/v0.2.0 branch November 22, 2022 16:50
@lbenet
Copy link

lbenet commented Nov 22, 2022

Thanks a lot @giordano !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants