New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move JLLs to own folder #79064
Move JLLs to own folder #79064
Conversation
Nice, we'll have to ensure Registrator doesn't freak out by this (and it should also be updated to register new jlls in this subdir) but I think this is a good idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me!
IIRC, Ygg uses RegistryTools to create the registration PRs (not Registrator), so we'd need to apply the changes there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM!
Let's make the necessary changes to RegistryTools before we merge this PR?
b93b51a
to
099bde9
Compare
Can we merge this, or do we need to rebuild a manifest on some Yggdrasil bot? |
I think we need JuliaPackaging/BinaryBuilder.jl#1267 |
that was merged and then reverted. Meanwhile this PR has gained conflicts. |
AutoMerge will be unhappy about new jll registrations unless RegistryCI is updated with the new RegistryTools version. But that's not compatible with Julia < 1.6 so JuliaRegistries/RegistryTools.jl#85 might need to be backported to a new RegistryTools 1.x release as well. |
I've released a new RegistryTools 2.2 that restores compatibility with Julia 1.1+. We need to merge JuliaRegistries/RegistryCI.jl#500 and register RegistryCI 8.3. Then we need to update the CI manifest in the General registry to use RegistryCI 8.3. |
So current blocker is yggdrasil to the new registry tools? |
JuliaPackaging/BinaryBuilder.jl#1269 Someone need to review and merge that PR. |
OK, I believe there should no longer be any blockers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM. Can you run the script again? And then we can quickly merge before more conflicts arise.
3edc0b6
to
68cf30d
Compare
This implements @KristofferC 's idea from #78672 (comment)
and should (for now at least) close #78672
the script i used to do this is: