Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: ACSets v0.1.0 #84268

Merged
merged 1 commit into from May 30, 2023

Conversation

JuliaRegistrator
Copy link
Contributor

  • Registering package: ACSets
  • Repository: https://github.com/AlgebraicJulia/ACSets.jl
  • Created by: @epatters
  • Version: v0.1.0
  • Commit: 672186a05a6b298417223d4c1cb01d34fd59ab92
  • Git reference: HEAD
  • Description: ACSets: Algebraic databases as in-memory data structures

UUID: 227ef7b5-1206-438b-ac65-934d6da304b8
Repo: https://github.com/AlgebraicJulia/ACSets.jl.git
Tree: 687d6797b8a92d0f769a4caf6ed2aabcb7bcf025

Registrator tree SHA: 7242ef64be5953fac9bf8b3efa3a7c4d2d44ca09
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch May 26, 2023 01:57 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Your new package pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README and the AutoMerge guidelines. The following guidelines were not met:

  • Package name similar to 1 existing package.
    1. Similar to Assets. Damerau-Levenshtein distance 2 is at or below cutoff of 2. Damerau-Levenshtein distance 1 between lowercased names is at or below cutoff of 1.

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

After you have fixed the AutoMerge issues, simple retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number).

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the #pkg-registration channel in the Julia Slack to ask for help. Include a link to this pull request.

Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

@epatters
Copy link
Contributor

Sorry for the trouble, but I would like to request that this PR be manually merged on the grounds that

  • The two packages concern very different domains (databases/data structures and finance)
  • "ACSets" is a made-up word (short for "attributed C-sets"), so in any case is unlikely to be confused with other things
  • We've been using this word in our software and writings for several years now

Thanks!

@StefanKarpinski
Copy link
Contributor

Using the "what are the words you use to describe it" method, it seems like AttributedCSets would be a better name.

@rafaqz
Copy link
Contributor

rafaqz commented May 27, 2023

+1 to AttributedCSets.jl

@epatters
Copy link
Contributor

Thanks for the suggestions. However, the AlgebraicJulia team would prefer the original name since that is the name that we have been using and are now accustomed to.

Can this PR please be manually merged?

@rafaqz
Copy link
Contributor

rafaqz commented May 30, 2023

https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1

Did everyone read this and disagree with the reasoning?

@epatters
Copy link
Contributor

Point taken. We'll rename the package (name TBD). This PR can be closed. Thanks.

@mehalter
Copy link

@epatters @rafaqz actually I believe changing the name here goes against the package naming guidelines. Pointedly guideline 3: "Packages that provide most of their functionality in association with a new type should have pluralized names."

This package purely exports the ACSet type and functionality for this type. Therefore it should be named ACSets.jl

This would also align with the Python implementation package py-acsets which we would like to maintain a common naming convention with.

@jpfairbanks
Copy link

I agree with @mehalter that guideline 3 exceeds the value of guideline 1 in this case. AttributedCSets is still jargon, since CSet is a play on the name G-Set for a group action, which is jargon from abstract algebra.

@rafaqz
Copy link
Contributor

rafaqz commented May 30, 2023

Sure! That makes sense.

I was making the point that wanting the name anyway should be in reference to the guidelines and your situation, not just a preference. Because everyone prefers their own idea.

Now you just need to convince someone who actually has commit rights :)

@JeffBezanson
Copy link
Contributor

I'm ok with this; I don't find Assets and ACSets very confusable.

@fredrikekre fredrikekre merged commit 2bbe60e into master May 30, 2023
19 of 21 checks passed
@fredrikekre fredrikekre deleted the registrator-acsets-227ef7b5-v0.1.0-7701e7aa6a branch May 30, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants