Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If there are multiple entries in [compat] that are in neither [deps] not [extras], Registrator only tells you one at a time #237

Closed
DilumAluthge opened this issue Oct 20, 2019 · 1 comment · Fixed by #238
Closed

If there are multiple entries in [compat] that are in neither [deps] not [extras], Registrator only tells you one at a time #237

DilumAluthge opened this issue Oct 20, 2019 · 1 comment · Fixed by #238

Comments

@DilumAluthge
Copy link
Member

Scenario: Suppose that your package has N entries under [extras] that appear in neither [deps] nor [extras].

Expected behavior: Registrator posts a single comment that lists all N bad entries.

Actual behavior: Registrator posts one comment that lists one of the bad entries. You remove that entry from [compat], and then re-trigger Registrator. Then, Registrator posts a second comment that lists another one of the bad entries. The cycle continues one at a time until all of the bad entries have been removed. In total, Registrator will post N separate comments.

Examples:

Thanks to @caseykneale for initially reporting this.
@DilumAluthge
Copy link
Member Author

Here's a screenshot to illustrate:

Screen Shot 2019-10-20 at 18 02 26

@nkottary nkottary mentioned this issue Oct 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show invalid entries in [compat] together nkottary/Registrator.jl
1 participant
@DilumAluthge