Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show invalid entries in [compat] together #238

Merged
merged 2 commits into from
Oct 21, 2019

Conversation

nkottary
Copy link
Member

Fix #237

@DilumAluthge
Copy link
Member

Thanks for such a quick fix!

@codecov-io
Copy link

codecov-io commented Oct 21, 2019

Codecov Report

Merging #238 into master will decrease coverage by 6.78%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #238      +/-   ##
=========================================
- Coverage    15.2%   8.41%   -6.79%     
=========================================
  Files          26      26              
  Lines        1263    1272       +9     
=========================================
- Hits          192     107      -85     
- Misses       1071    1165      +94
Impacted Files Coverage Δ
src/regedit/register.jl 8.8% <0%> (-0.36%) ⬇️
src/webui/routes/select.jl 0% <0%> (-100%) ⬇️
src/webui/providers.jl 0% <0%> (-100%) ⬇️
src/webui/routes/index.jl 0% <0%> (-100%) ⬇️
src/webui/webutils.jl 7.14% <0%> (-71.43%) ⬇️
src/webui/routes/register.jl 0% <0%> (-47.23%) ⬇️
src/webui/WebUI.jl 1.47% <0%> (-35.15%) ⬇️
src/webui/gitutils.jl 0.73% <0%> (-11.21%) ⬇️
src/management.jl 0% <0%> (-10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70aee7c...775d5ed. Read the comment docs.

@nkottary
Copy link
Member Author

No problem. It still needs to be deployed. I will update once that happens.

@nkottary nkottary merged commit 5790e63 into JuliaRegistries:master Oct 21, 2019
@nkottary nkottary deleted the nk/fix_msg branch October 21, 2019 11:31
@nkottary
Copy link
Member Author

This is deployed.

nkottary added a commit to nkottary/Registrator.jl that referenced this pull request Apr 10, 2020
* Show invalid entries in [compat] together

* Ignore julia
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants