New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebUI: Check for existing PR and update #163
Conversation
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
=========================================
- Coverage 14.53% 14.14% -0.4%
=========================================
Files 27 27
Lines 1156 1188 +32
=========================================
Hits 168 168
- Misses 988 1020 +32
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The place that calls make_registration_request
definitely is not expecting for an exception to be thrown... Places that throw exceptions should be returning the GitForge.result
back to the caller. The @gf
macro will handle logging the exception.
Needs: JuliaWeb/GitForge.jl#6