Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI: Check for existing PR and update #163

Merged
merged 9 commits into from May 20, 2019
Merged

WebUI: Check for existing PR and update #163

merged 9 commits into from May 20, 2019

Conversation

nkottary
Copy link
Member

@codecov-io
Copy link

codecov-io commented May 18, 2019

Codecov Report

Merging #163 into master will decrease coverage by 0.39%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #163     +/-   ##
=========================================
- Coverage   14.53%   14.14%   -0.4%     
=========================================
  Files          27       27             
  Lines        1156     1188     +32     
=========================================
  Hits          168      168             
- Misses        988     1020     +32
Impacted Files Coverage Δ
src/webui/gitutils.jl 13.97% <0%> (-7.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19e462e...c468a5b. Read the comment docs.

Copy link
Member

@christopher-dG christopher-dG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The place that calls make_registration_request definitely is not expecting for an exception to be thrown... Places that throw exceptions should be returning the GitForge.result back to the caller. The @gf macro will handle logging the exception.

src/webui/gitutils.jl Outdated Show resolved Hide resolved
src/webui/gitutils.jl Outdated Show resolved Hide resolved
src/webui/gitutils.jl Outdated Show resolved Hide resolved
src/webui/gitutils.jl Outdated Show resolved Hide resolved
src/webui/gitutils.jl Outdated Show resolved Hide resolved
src/webui/gitutils.jl Outdated Show resolved Hide resolved
src/webui/gitutils.jl Outdated Show resolved Hide resolved
@nkottary nkottary merged commit f6fe196 into master May 20, 2019
@nkottary nkottary deleted the nk/checkpr branch May 20, 2019 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants