WebUI: Check for existing tag #202
Conversation
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
==========================================
- Coverage 13.4% 13.16% -0.24%
==========================================
Files 27 27
Lines 1216 1238 +22
==========================================
Hits 163 163
- Misses 1053 1075 +22
Continue to review full report at Codecov.
|
| end | ||
|
|
||
| function tagexists(forge::GitLabAPI, project::GitLab.Project, tag::VersionNumber) | ||
| # Using Registrator's token here instead of the users. This is |
There was a problem hiding this comment.
FYI pretty much every non-write GitLab interaction is done with the Registrator API key instead of the user's, so this comment isn't really necessary in this particular spot. I thought I had it written down in a comment somewhere but perhaps not.
There was a problem hiding this comment.
I left it as a note to myself when I have to support registration for private packages.
| end | ||
| v == string(tag) && return true | ||
| end | ||
| false |
There was a problem hiding this comment.
| false | |
| return false |
There was a problem hiding this comment.
I typically use return to return and break out of a block. If its the last line I avoid using an extra keyword.
| end | ||
| v == string(tag) && return true | ||
| end | ||
| false |
There was a problem hiding this comment.
| false | |
| return false |
|
I don't know why the test is failing: |
|
You probably need to update the manifest. |
Address #194 for WebUI