Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require compat bounds for package which don't exist #530

Open
giordano opened this issue Nov 4, 2023 · 2 comments
Open

Don't require compat bounds for package which don't exist #530

giordano opened this issue Nov 4, 2023 · 2 comments
Labels
automerge comment registry consistency tests

Comments

@giordano
Copy link
Member

giordano commented Nov 4, 2023

JuliaRegistries/General#94736 (comment) initially complained that I didn't have compat bounds on Printf, which is a stdlib but doesn't exist in the registry at the moment, so I added it in JuliaPhysics/Measurements.jl#161, with the result that the package now is uninstallable in Julia v1.0-1.6 because Printf doesn't exist: JuliaPhysics/Measurements.jl#162. I don't think automerge should suggest adding compat bounds on packages which don't exist in the registry in the first place.
@giordano giordano mentioned this issue Nov 4, 2023
Closed
giordano added a commit to JuliaRegistries/General that referenced this issue Nov 4, 2023
@giordano
[Measurements] Remove compat on Printf which makes package uninstal…
4fc6b81 
…lable

See JuliaRegistries/RegistryCI.jl#530.

Fix JuliaPhysics/Measurements.jl#162.
This was referenced Nov 4, 2023
Merged
Merged
Open
giordano added a commit to JuliaRegistries/General that referenced this issue Nov 4, 2023
@giordano
[Measurements] Remove compat on Printf which makes package uninstal…
74251e0 
…lable (#94758)

See JuliaRegistries/RegistryCI.jl#530.

Fix JuliaPhysics/Measurements.jl#162.
@vchuravy
Copy link
Member

vchuravy commented Nov 4, 2023

The answer here is that we need to add them to the registry.

@giordano
Copy link
Member Author

giordano commented Nov 4, 2023

Sure, but consistency checks should prevent these situations 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
automerge comment registry consistency tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vchuravy @giordano