Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that there are "enough" tests and documentation #492

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Commits on Jan 16, 2023

  1. Configuration menu
    Copy the full SHA
    fad9538 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Configuration menu
    Copy the full SHA
    ec8f556 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. Configuration menu
    Copy the full SHA
    11026cd View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. Configuration menu
    Copy the full SHA
    881dfba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ebf74b8 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. Configuration menu
    Copy the full SHA
    a6a07ac View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Further work on new Guideline guideline_linecounts_meet_thresholds to

    check that a new package has enough test code and documentation.
    
    Use a Dict to pass Guideline parameters from the arglist of run
    opaquely through pull_request_build and check! to the various
    guidelines.  Existing guideline parameters have not yet been moved to
    this Dict.  Added this Dict parameter to every Guideline check
    function.
    
    Report which keyword arguments are missing from GitHubAutoMergeData
    using @warn.
    
    Moved new code from previous change in src/utils.jl to
    src/AutoMerge/util.jl.
    
    Extracted depot setup code from AutoMerge.parse_registry_pkg_info to
    new function setup_depot so that it is available to other guideline
    tests.
    
    "AutoMerge.linecounts_meet_thresholds" testset passes.
    MarkNahabedian committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    94f7a69 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dd04259 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    eee7c51 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d0b9996 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Configuration menu
    Copy the full SHA
    37bf9b6 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Update src/AutoMerge/guidelines.jl

    Co-authored-by: Eric Hanson <5846501+ericphanson@users.noreply.github.com>
    MarkNahabedian and ericphanson committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    1b9e848 View commit details
    Browse the repository at this point in the history
  2. Update src/AutoMerge/guidelines.jl

    Co-authored-by: Eric Hanson <5846501+ericphanson@users.noreply.github.com>
    MarkNahabedian and ericphanson committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    75cbbf3 View commit details
    Browse the repository at this point in the history
  3. Revert 37bf9b6 since the problem it was intended to fix happens much …

    …earlier. Make sure guideline_distance_check is last, as the comment says it should be.
    MarkNahabedian committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    48eb348 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cc90730 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6484879 View commit details
    Browse the repository at this point in the history
  6. Set defaults parameter values for guideline_linecounts_meet_threshold…

    …s in fun, as well as in the guideline function. Set the defaults to 0 so that once this code isa in place, the guideline is a no-op until configured in a workflow.
    MarkNahabedian committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    f36a8e0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4ed3e65 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    edcf26d View commit details
    Browse the repository at this point in the history
  9. Update Project.toml

    ericphanson committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    f8b1275 View commit details
    Browse the repository at this point in the history
  10. Oops. Meant to remove the linecount thresholds from GitHubAutoMergeDa…

    …ta when I created the parameters Dict.
    MarkNahabedian committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    8c1dd57 View commit details
    Browse the repository at this point in the history
  11. Version gate for guideline_linecounts_meet_thresholds because Package…

    …Analyzer requires Julia version >= 1.6.
    MarkNahabedian committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    507a16c View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    92fa52f View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Add a separate set of parameters for ratio thresholds.

    Failure messages with too much information.
    
    Remove meets_threshold, which is no longer needed.
    MarkNahabedian committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    d1e04e6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fc1d378 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. Update Project.toml

    MarkNahabedian committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    04ef6f3 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. Configuration menu
    Copy the full SHA
    8155a87 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Update src/AutoMerge/guidelines.jl documentation of parameters for gu…

    …ideline_linecounts_meet_thresholds.
    
    Co-authored-by: Eric Hanson <5846501+ericphanson@users.noreply.github.com>
    MarkNahabedian and ericphanson committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    009fae8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c8ea113 View commit details
    Browse the repository at this point in the history
  3. remove using Logging.

    MarkNahabedian committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    5d45493 View commit details
    Browse the repository at this point in the history
  4. Fix typo.

    Co-authored-by: Eric Hanson <5846501+ericphanson@users.noreply.github.com>
    MarkNahabedian and ericphanson committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    5f2d565 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f14b2a6 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Attempt to accomodate those projects which shoose to put all of their…

    … documentation in their README file rather than using conventional Julia documentation.
    MarkNahabedian committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    58eb4be View commit details
    Browse the repository at this point in the history