Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the AutoMerge logs, explain to users that the "Error: Some registries failed to update" and "registry dirty" messages should be ignored #504

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

DilumAluthge
Copy link
Member

No description provided.

…ies failed to update" and "registry dirty" messages should be ignored
@DilumAluthge
Copy link
Member Author

@giordano What do you think?

@giordano
Copy link
Member

Is this message close enough to the error messages? Otherwise I'm worried users won't easily see it.

@DilumAluthge
Copy link
Member Author

Good question. Let's do a test run and see what the logs look like.

bors try

bors bot added a commit that referenced this pull request Apr 13, 2023
@DilumAluthge
Copy link
Member Author

IMG_0929

@giordano
Copy link
Member

Bump? I thought this was merged, and users are still confused by the error message: https://discourse.julialang.org/t/juliaregistries-cant-update-my-package-because-of-registry-dirty/89379

@DilumAluthge
Copy link
Member Author

bors merge

bors bot added a commit that referenced this pull request Oct 11, 2023
504: In the AutoMerge logs, explain to users that the "Error: Some registries failed to update" and "registry dirty" messages should be ignored r=DilumAluthge a=DilumAluthge



Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
@bors
Copy link
Contributor

bors bot commented Oct 11, 2023

Build failed:

@DilumAluthge
Copy link
Member Author

I completely forgot that we never merged this PR. Let's get it in.

@DilumAluthge DilumAluthge added this pull request to the merge queue Jun 4, 2024
Merged via the queue into master with commit 1714373 Jun 4, 2024
10 of 11 checks passed
@DilumAluthge DilumAluthge deleted the dpa/dirty branch June 4, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants