Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup_depot for setting up a temporary depot for testing. #506

Merged
merged 4 commits into from
Apr 30, 2023

Conversation

MarkNahabedian
Copy link
Contributor

I was asked to break up #492 into several parts.

This PR introduces the function setup_depot which pulls out the code for creating a temporary depot during testing so that it is easier to use in other places.

Copy link
Member

@ericphanson ericphanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would name it setup_global_depot so it's clear that 1 depot is shared by all invocations of the function (rather than a separate one each time). Otherwise, looks good to me!

test/automerge-unit.jl Outdated Show resolved Hide resolved
test/automerge-unit.jl Outdated Show resolved Hide resolved
MarkNahabedian and others added 2 commits April 30, 2023 13:21
Co-authored-by: Eric Hanson <5846501+ericphanson@users.noreply.github.com>
Th

Co-authored-by: Eric Hanson <5846501+ericphanson@users.noreply.github.com>
@ericphanson
Copy link
Member

Bors merge

@bors bors bot merged commit 3fb1b5d into JuliaRegistries:master Apr 30, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants