-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added AutomaticDefault module #47
Conversation
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
- Coverage 74.46% 70.12% -4.34%
==========================================
Files 3 6 +3
Lines 47 77 +30
==========================================
+ Hits 35 54 +19
- Misses 12 23 +11
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Ok, this is done! This is a fairly significant addition, so I will wait a few days for comments from any stakeholders (@the-one-and-only-jackson, @findmyway , @jeremiahpslewis, @HenriDeh ). If anyone wants to give a review, it is welcome! |
Hearing no objections, I am going to merge this. |
This allows an algorithm writer to do, for example
Then clone will automatically try to use the
clone
provided by the environment, or fall back todeepcopy
. Similarlyvalid_actions
will use an environment'svalid_actions
orvalid_action_mask
or fall back toactions
.Still need to provide documentation. This will close #44 . I decided there was no need for an
Optional
module.