Update TFRecord.jl to work with julia 1.7+ and ProtoBuf v1.0+ #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
+ Coverage 53.26% 56.88% +3.61%
==========================================
Files 2 2
Lines 306 276 -30
==========================================
- Hits 163 157 -6
+ Misses 143 119 -24
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Avoid breaking change
|
Thanks! Just realized that ProtoBuf.jl@v1 released. I modified this PR slightly to keep it working on v1.6 (A new version will be tagged soon) JuliaRegistries/General#69686 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I have updated the package to work with new versions of the dependencies, in particular ProtoBuf.
The test cases are passed successfully, but please check that Tensorflow can read the tfrecord files properly before merging. Have a good day!