Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation output showing in the newly built docs #163

Open
akabla opened this issue Mar 4, 2024 · 6 comments
Open

Installation output showing in the newly built docs #163

akabla opened this issue Mar 4, 2024 · 6 comments

Comments

@akabla
Copy link
Member

akabla commented Mar 4, 2024

          BTW, I'm not sure why but there's some installation output showing in the newly built docs that wasn't there before:

https://juliarheology.github.io/RHEOS.jl/dev/examples/

Originally posted by @moustachio-belvedere in #161 (comment)

@akabla
Copy link
Member Author

akabla commented Mar 4, 2024

I tried to stop this output with ";", but it doesn't help here.

@moustachio-belvedere
Copy link
Member

moustachio-belvedere commented Mar 5, 2024

I found updating the docs/ project environment to remove Conda and PyCall (possible now due to your removal of explicit PyCall usage) and upgrading didn't produce the output locally which is promising.

@moustachio-belvedere
Copy link
Member

If this doesn't help on the remote build I think we can get the CI pipeline to force an early PyPlot installation before the doc build gets triggered

@moustachio-belvedere
Copy link
Member

Actually, adding this near the top of docs/make.jl might be better than changing CI:

using Pkg
ENV["PYTHON"]=""
Pkg.build("PyCall")
using PyCall
pyimport_conda("matplotlib.pyplot", "matplotlib")

@akabla
Copy link
Member Author

akabla commented Mar 6, 2024

Actually, adding this near the top of docs/make.jl might be better than changing CI:

using Pkg
ENV["PYTHON"]=""
Pkg.build("PyCall")
using PyCall
pyimport_conda("matplotlib.pyplot", "matplotlib")

Thanks Louis, that fixed it!

We might as well simplify the environment and remove Conda and Pycall. I leave this open for now.

@moustachio-belvedere
Copy link
Member

Sounds good. Though I think with the above fix we'll have to leave PyCall in as an explicit dependency. (Conda will still be a dependency but can prob be relegated to an implicit one.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants