Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and update hyperlinks #503

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Conversation

alexfreudenberg
Copy link
Contributor

Maybe relative links to internal files would help to avoid breaking them?

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.07 ⚠️

Comparison is base (5a4d58f) 85.89% compared to head (a4e82a5) 85.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #503      +/-   ##
==========================================
- Coverage   85.89%   85.83%   -0.07%     
==========================================
  Files          39       39              
  Lines        9571     9571              
==========================================
- Hits         8221     8215       -6     
- Misses       1350     1356       +6     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chriselrod chriselrod merged commit befd727 into JuliaSIMD:main Jun 29, 2023
51 of 59 checks passed
@chriselrod
Copy link
Member

Thanks!
But in this case the problem was that the files changed directories, e.g. moving from src to src/modeling. This break would not have been avoided by making the paths relative.

@alexfreudenberg alexfreudenberg deleted the patch-1 branch June 29, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants