rfftfreq not defined

[dylanmikesell]

I recently updated to Julia 1.3.1 after seeing that SeisIO issues have been fixed. I tried to run the SeisNoise example on the github front page of the repository. I am now getting the following error.

WARNING: both FFTW and DSP export "rfftfreq"; uses of it in module SeisNoise must be qualified

Looks like there is a problem in these two packages and we need to modify SeisNoise to choose which we are using: FFTW or DSP. Have you seen this error yet and is there a plan to fix it?

The problem occurs on line 29 of phase_shift.jl

freq = rfftfreq(length(C.x),C.fs)

[tclements]

I have not updated to Julia 1.3.x yet - I'll update and add a fix shortly

[tclements]

This was fixed on the master branch but was not pushed to the Julia General registry. I updated the package number such that the master branch is now on the General registry. Once this pull request JuliaRegistries/General#10013 is merged, you should be able to do pkg> update SeisNoise to fix.

[tclements]

Just waiting for the Julia general to merge JuliaRegistries/General#10015

[dylanmikesell]

Okay. Will check back in once this is merged. I tried updating this morning, but doesn't look like registry has updated SeisNoise yet. Will try again tonight. Not sure how quickly that merge happens.

…

On Tue, Feb 25, 2020 at 6:14 PM Tim Clements ***@***.***> wrote: Just waiting for the Julia general to merge JuliaRegistries/General#10015 <JuliaRegistries/General#10015> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#11>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVIE4UBTWZK75HVH5RVVF3REW7ANANCNFSM4K2Q2RQQ> .

[tclements]

You can also add the master version of SeisNoise, which is passing builds.

pkg> rm SeisNoise
pkg> add SeisNoise#master

[dylanmikesell]

Good to know. Will do that! Dylan

…

On Wed, Feb 26, 2020 at 8:06 AM Tim Clements ***@***.***> wrote: You can also add the master version of SeisNoise, which is passing builds. pkg> rm SeisNoise pkg> add SeisNoise#master — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#11>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVIE4UCH4PIUYJLALBQS63RE2ANNANCNFSM4K2Q2RQQ> .

[tclements]

The PR to General finally merged. This should be fixed with pkg> update SeisNoise. Future version bumps should automerge now that I have the Julia compat system setup.