Support for request kwargs in object.jl #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnj
reviewed
Jan 30, 2023
| @@ -177,7 +178,7 @@ mutable struct PrefetchedDownloadStream{T <: Object} <: IO | |||
| prefetch_multipart_size > 0 || throw(ArgumentError("`prefetch_multipart_size` must be positive, got $prefetch_multipart_size")) | |||
| if size > 0 | |||
| for _ in 1:min(Threads.nthreads(), max(1, div(size, io.prefetch_multipart_size))) | |||
| Threads.@spawn _download_task($io) | |||
| Threads.@spawn _download_task($io; $kw...) | |||
There was a problem hiding this comment.
Can you do a quick local check to make sure this works? My gut says I don't know if it should be ($io; $(kw...)) or what you have here, but maybe it doesn't make a difference. Can you just double check by printing keyword args in CloudBase or HTTP to make sure things are getting passed through correctly? I'd hate to update things and then discover later that specific tasks weren't getting keywords passed through right.
There was a problem hiding this comment.
Yeah I wasn't sure as well so I made this little experiment:
x = [1,2,3]
for _ in 1:5 # works
Threads.@spawn println($x...)
end
for _ in 1:5 # error
Threads.@spawn println($(x...))
end
for _ in 1:5 # works
Threads.@spawn println($(x)...)
end
quinnj
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.