Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for mixed models (NLP) #180

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Add test for mixed models (NLP) #180

merged 1 commit into from
Jul 13, 2023

Conversation

tmigot
Copy link
Member

@tmigot tmigot commented Jul 13, 2023

I catch a bug where with the current system calling hprod and hess allocate because the vector y is expected of size ncon and not nnln.

#178

@tmigot tmigot added the tests Everything related to tests label Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.60 🎉

Comparison is base (1b615ea) 93.40% compared to head (e90becc) 94.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   93.40%   94.00%   +0.60%     
==========================================
  Files          13       14       +1     
  Lines        1622     1651      +29     
==========================================
+ Hits         1515     1552      +37     
+ Misses        107       99       -8     
Impacted Files Coverage Δ
src/ad_api.jl 92.66% <100.00%> (+4.78%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Package name latest stable
CaNNOLeS.jl
DCISolver.jl
DerivativeFreeSolvers.jl
JSOSolvers.jl
NLPModelsIpopt.jl
OptimizationProblems.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl

@tmigot tmigot merged commit de8326e into main Jul 13, 2023
37 of 38 checks passed
@tmigot tmigot deleted the add-mixed-tests branch July 13, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Everything related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant