add linear API in NLS constructor #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmigot
force-pushed
the
add-nls-linear-constructors
branch
from
af23057
to
664505f
Compare
|
dpo
approved these changes
Aug 4, 2022
|
|
||
| ADNLSModel is an Nonlinear Least Squares model using automatic differentiation to | ||
| compute the derivatives. | ||
| The problem is defined as | ||
|
|
||
| min ½‖F(x)‖² | ||
| s.to lcon ≤ c(x) ≤ ucon | ||
| s.to lcon ≤ ( Ax ) ≤ ucon | ||
| ( c(x) ) |
There was a problem hiding this comment.
Maybe just to make it clear, state that the linear constraints comes first in the list of constraints.
And so, do you still need the keyword linequ below?
There was a problem hiding this comment.
On second reading, maybe linequ is to indicate linear residuals. If so, that could be explained more clearly.
There was a problem hiding this comment.
the linear part of the residual is a bit work to be done, so I will had to the todo-list this clarification. Thanks
|
Excellent, thank you! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the NLS-version of #69
Again this is extracted from the large PR #66 (so I refer to #66 for the unit tests)