Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal solver structure #60

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Add minimal solver structure #60

merged 1 commit into from
Oct 21, 2022

Conversation

tmigot
Copy link
Member

@tmigot tmigot commented Oct 17, 2022

No description provided.

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 84.93% // Head: 84.05% // Decreases project coverage by -0.88% ⚠️

Coverage data is based on head (6d1f4ca) compared to base (e1ee261).
Patch coverage: 81.25% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   84.93%   84.05%   -0.89%     
==========================================
  Files           2        2              
  Lines         385      395      +10     
==========================================
+ Hits          327      332       +5     
- Misses         58       63       +5     
Impacted Files Coverage Δ
src/CaNNOLeS.jl 84.79% <81.25%> (-0.93%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@tmigot tmigot merged commit 73b42c2 into main Oct 21, 2022
@tmigot tmigot deleted the add-minimal-structure branch October 21, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants